-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT] Added custom share text option. #99
Conversation
b776746
to
e01e5d6
Compare
{ | ||
|
||
Log.d(LCAT, "start showShareSheet()"); | ||
|
||
ShareSheetStyle shareSheetStyle = new ShareSheetStyle(this.activity, "Check this out!", "This stuff is awesome: ") | ||
ShareSheetStyle shareSheetStyle = new ShareSheetStyle(this.activity, "Check this out!", shareText) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should expose the title as well instead of hard coding it to "Check this out!"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I supposed, however iOS doesn't have a functionality to modify the share title text according to @jestoniyap . So atm I disregarded the modification of the title, though I can still add the functionality for Android but not on iOS. If it's okay with you.
Can you add this argument to iOS as well? |
Hey @aaustin , |
Sounds good. See my other note though? |
Yes, however I also consulted @jestoniyap in regards to the iOS. |
Ok sounds good. Thanks. Can you fix the merge conflicts first? |
e01e5d6
to
ad5c2a5
Compare
@aaustin fixed merge conflict. |
👍 |
Added option for customizing share text.